diegomedina248 opened a new pull request, #19967:
URL: https://github.com/apache/superset/pull/19967

   ### SUMMARY
   The database connection modal fires a callback when a db is successfully 
connected.
   The problem is, the database list cannot listen to that callback when the 
modal is displayed/shown outside of the container.
   
   This PR enables that functionality via query params, so that the database 
list can be notified and refreshed.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   
https://user-images.githubusercontent.com/17252075/167051414-66692bdf-5035-445e-bf54-bca263a71c15.mov
   
   After:
   
   
https://user-images.githubusercontent.com/17252075/167051400-c73503c1-2306-4f44-9354-220f89a0f157.mov
   
   ### TESTING INSTRUCTIONS
   Go to the dashboard list and connect a new database from the top "plus 
button" menu.
   Ensure you can see the newly connected database without refreshing the page.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to