stephenLYZ commented on code in PR #19967:
URL: https://github.com/apache/superset/pull/19967#discussion_r887522051
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx:
##########
@@ -503,7 +503,6 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps>
= ({
setImportingModal(false);
setPasswords({});
setConfirmedOverwrite(false);
- if (onDatabaseAdd) onDatabaseAdd();
Review Comment:
I'm curious about the reason for the deletion here, it looks like the
`close` method will be called in multiple places, not just the model closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
