michael-s-molina commented on code in PR #19981:
URL: https://github.com/apache/superset/pull/19981#discussion_r870535403
##########
superset/explore/form_data/commands/update.py:
##########
@@ -64,7 +65,7 @@ def run(self) -> Optional[str]:
# Generate a new key if tab_id changes or equals 0
tab_id = self._cmd_params.tab_id
contextual_key = cache_key(
- session.get("_id"), tab_id, dataset_id, chart_id
+ session.get("_id"), tab_id, datasource_id, chart_id,
datasource_type
Review Comment:
It will miss the cache here for old keys because they were generated without
the `datasource_type`. We can add logic to also query for the old format or
assume that new keys will be created and think about how to clean the old
entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
