eschutho commented on code in PR #19981:
URL: https://github.com/apache/superset/pull/19981#discussion_r872888975
##########
superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx:
##########
@@ -189,9 +189,10 @@ class DatasourceControl extends React.PureComponent {
const isMissingDatasource = datasource.id == null;
let isMissingParams = false;
if (isMissingDatasource) {
- const datasetId = getUrlParam(URL_PARAMS.datasetId);
+ const datasourceId = getUrlParam(URL_PARAMS.datasourceId);
+ const datasourceType = getUrlParam(URL_PARAMS.datasourceType);
const sliceId = getUrlParam(URL_PARAMS.sliceId);
- if (!datasetId && !sliceId) {
+ if (!datasourceId && !sliceId && !datasourceType) {
Review Comment:
Thanks, sounds good. I think we set a default for type then we won't be able
to validate if it's missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
