kgabryje commented on code in PR #20049:
URL: https://github.com/apache/superset/pull/20049#discussion_r872505756
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx:
##########
@@ -125,37 +125,45 @@ test('Should render default props', () => {
delete props.sliceCanEdit;
render(<SliceHeaderControls {...props} />, { useRedux: true });
- userEvent.click(screen.getByRole('menuitem', { name: 'Maximize chart' }));
- userEvent.click(screen.getByRole('menuitem', { name: /Force refresh/ }));
- userEvent.click(
- screen.getByRole('menuitem', { name: 'Toggle chart description' }),
- );
- userEvent.click(
- screen.getByRole('menuitem', { name: 'View chart in Explore' }),
- );
- userEvent.click(screen.getByRole('menuitem', { name: 'Export CSV' }));
- userEvent.click(screen.getByRole('menuitem', { name: /Force refresh/ }));
+ expect(
+ screen.getByRole('menuitem', { name: 'Enter fullscreen' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('menuitem', { name: /Force refresh/ }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('menuitem', { name: 'Show chart description' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('menuitem', { name: 'Edit chart' }),
+ ).toBeInTheDocument();
+ expect(
+ screen.getByRole('menuitem', { name: 'Download' }),
+ ).toBeInTheDocument();
+ expect(screen.getByRole('menuitem', { name: 'Share' })).toBeInTheDocument();
expect(
screen.getByRole('button', { name: 'More Options' }),
).toBeInTheDocument();
expect(screen.getByTestId('NoAnimationDropdown')).toBeInTheDocument();
});
-test('Should "export to CSV"', () => {
+test('Should "export to CSV"', async () => {
const props = createProps();
render(<SliceHeaderControls {...props} />, { useRedux: true });
expect(props.exportCSV).toBeCalledTimes(0);
- userEvent.click(screen.getByRole('menuitem', { name: 'Export CSV' }));
+ userEvent.hover(screen.getByText('Download'));
+ userEvent.click(await screen.findByText('Export to .CSV'));
expect(props.exportCSV).toBeCalledTimes(1);
expect(props.exportCSV).toBeCalledWith(371);
});
test('Should not show "Export to CSV" if slice is filter box', () => {
const props = createProps('filter_box');
render(<SliceHeaderControls {...props} />, { useRedux: true });
- expect(screen.queryByRole('menuitem', { name: 'Export CSV' })).toBe(null);
+ userEvent.hover(screen.getByText('Download'));
Review Comment:
Good point! In this particular example I changed the logic so that
"Download" submenu is not rendered at all for filter box. Fixed in the rest of
tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
