kgabryje commented on PR #20049: URL: https://github.com/apache/superset/pull/20049#issuecomment-1126165224
> Thanks for the PR @kgabryje. I'm assuming that we will have another one coming for the dashboard options as well (to make them consistent). > > I'm not sure if it's related but clicking on Download as image is raising the following exception: > > <img alt="Screen Shot 2022-05-13 at 10 43 36 AM" width="526" src="https://user-images.githubusercontent.com/70410625/168296919-b3fffbdf-5c93-4c60-a1c4-e7d5e0866e92.png";> Well spotted. The problem was that the menu renders in the chart holder in DOM tree, but submenu is attached to the body and there's no way to specify popup container. I changed the screenshot selector from relative to absolute (each chart holder has a class specific to chart id, so it's easy to use exact selector to grab correct chart) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/70410625/168296919-b3fffbdf-5c93-4c60-a1c4-e7d5e0866e92.png"](https://user-images.githubusercontent.com/70410625/168296919-b3fffbdf-5c93-4c60-a1c4-e7d5e0866e92.png"){kind=link}