kgabryje commented on PR #20067: URL: https://github.com/apache/superset/pull/20067#issuecomment-1127365623
Thanks for tagging me Ville! My fix doesn't cover the scenario presented by @Gwitchr, so I think this should go in. I just wonder if we could break the loop quicker - instead of decrementing to below 0, maybe we could do a check like "if the size for font size x is the same as the size for x-1, return x". Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
