kgabryje commented on PR #20067: URL: https://github.com/apache/superset/pull/20067#issuecomment-1127367946
Also, it would be great to implement binary search for optimal font size instead of decrementing by 1 to improve performance, but that's definitely out of scope of this PR 🙂 Anyway, is the proposal from comment above is not viable or would require a large refactor, let's merge this fix (which is great!) and iterate on this later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
