ebaratte opened a new pull request, #20075:
URL: https://github.com/apache/superset/pull/20075

   ### SUMMARY
   
   This PR is an attempt to provide a way of customising the format of the 
numbers and currency displayed in superset frontend.
   It is linked to (at least) issues #3972, #18938, #11328, #8913
   Please also look at PR #17796, which provides a different approach to the 
same issue.  
   
   Design choice:
   - the user can change the following d3 **number** formatting parameters: 
decimal, thousands, grouping, currency, numerals, percent, minus and nan
   - this change does not include the **time formatting** parameters, since I 
believe it to be a different issue
   - unlike #17796, it does not tie the format to the `LANGUAGES` config key: 
the user can use different parameters for the frontend language and number 
formatting
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before
   
![image](https://user-images.githubusercontent.com/1301204/168559126-397f77d9-f815-448d-979f-00507ce8df49.png)
   
   
   After:
   
![image](https://user-images.githubusercontent.com/1301204/168558961-5496373d-c64b-4498-8ab8-60da0554f0c7.png)
   
   
   
   ### TESTING INSTRUCTIONS
   - in config.py, add a D3_FORMAT dictionary with [d3 locale 
settings](https://github.com/d3/d3-format/blob/main/README.md#locale_format) 
   - check the number formatting on any chart
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: #3972, #18938, #11328, #8913
   - [x] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to