kgabryje commented on code in PR #20010:
URL: https://github.com/apache/superset/pull/20010#discussion_r873524538
##########
superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx:
##########
@@ -517,6 +517,11 @@ const config: ControlPanelConfig = {
],
},
],
+ denormalizeFormData: formData => ({
+ ...formData,
+ metrics: formData.standardized_form_data.sharedFormData.metrics,
Review Comment:
Not sure if I follow - it looks to me like rows and columns in pivot table
do return to their original states?
https://user-images.githubusercontent.com/15073128/168563992-9d9749fb-61e4-4664-b0a5-f663a4ac40df.mov
Or do you mean that, for example, if both columns and rows in pivot table
contain a value `name`, then it gets deduplicated when switching to table but
`sourceControl` contains information that `name` originates from both `columns`
and `rows` in pivot table? If that's the point, I like this idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
