zhaoyongjie commented on code in PR #20010:
URL: https://github.com/apache/superset/pull/20010#discussion_r873704415
##########
superset-frontend/packages/superset-ui-chart-controls/src/types.ts:
##########
@@ -340,11 +341,26 @@ export interface ControlPanelSectionConfig {
controlSetRows: ControlSetRow[];
}
+export interface SharedFormData {
Review Comment:
Yes, the `sharedformData` is not an appropriate name here. Maybe
`SharedControlls` / `StandardizedState` is more direct. I am also considering
whether should we rename the `StandardizedFormData`(the class name) ->
`StandardizedFormDataState` or `IntermediateFormData`. How about you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
