codemaster08240328 opened a new pull request, #20119:
URL: https://github.com/apache/superset/pull/20119

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   When creating a report that sends a table chart with dates, and choose the 
option send by email as text, the dates show badly formatted
   
   It is because `/api/v1/chart/data` endpoint returns datetime64 data which 
represents as milliseconds.
   
   Need to convert is as date type when we create pandas Dataframe from the 
result data.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   BEFORE:
   
![image](https://user-images.githubusercontent.com/39701522/169124937-5248dca6-186f-4d35-a048-48831781cf7e.png)
   
   AFTER: 
   <img width="318" alt="image" 
src="https://user-images.githubusercontent.com/39701522/169124244-8da4661d-03a7-4114-aca8-5a657b2e190e.png";>
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   1. Create a table chart which contains date.
   2. Create a text email report.
   3. Check your email.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to