hughhhh commented on code in PR #20149:
URL: https://github.com/apache/superset/pull/20149#discussion_r878494676
##########
tests/integration_tests/query_context_tests.py:
##########
@@ -132,7 +132,7 @@ def
test_query_cache_key_changes_when_datasource_is_updated(self):
cache_key_original = query_context.query_cache_key(query_object)
# make temporary change and revert it to refresh the changed_on
property
- datasource = ConnectorRegistry.get_datasource(
+ datasource = DatasourceDAO.get_datasource(
datasource_type=payload["datasource"]["type"],
Review Comment:
use `DatasourceType(datasource.type)`
##########
tests/integration_tests/query_context_tests.py:
##########
@@ -156,7 +156,7 @@ def
test_query_cache_key_changes_when_metric_is_updated(self):
payload = get_query_context("birth_names")
# make temporary change and revert it to refresh the changed_on
property
- datasource = ConnectorRegistry.get_datasource(
+ datasource = DatasourceDAO.get_datasource(
Review Comment:
use `DatasourceType(datasource.type)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
