eschutho commented on code in PR #20149:
URL: https://github.com/apache/superset/pull/20149#discussion_r879673712
##########
superset/views/core.py:
##########
@@ -250,7 +254,7 @@ def override_role_permissions(self) -> FlaskResponse:
)
db_ds_names.add(fullname)
- existing_datasources =
ConnectorRegistry.get_all_datasources(db.session)
+ existing_datasources =
DatasourceDAO.get_all_sqlatables_datasources(db.session)
Review Comment:
I feel like if we know that the class is sqlatable, it shouldn't go through
the datasourceDao but rather the SqlaTable class or a SqlaTableDAO itself. I
think the datasourceDao should only be for looking up objects that could be any
one of the many new datasource types, but you don't specifically know which one
it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
