AAfghahi commented on code in PR #20283:
URL: https://github.com/apache/superset/pull/20283#discussion_r890526904
##########
superset/sqllab/sqllab_execution_context.py:
##########
@@ -76,7 +76,7 @@ def _init_from_query_params(self, query_params: Dict[str,
Any]) -> None:
self.sql = cast(str, query_params.get("sql"))
self.template_params = self._get_template_params(query_params)
self.async_flag = cast(bool, query_params.get("runAsync"))
- self.limit = self._get_limit_param(query_params)
+ self.limit = self._get_limit_param(self.sql, query_params)
Review Comment:
Query params does have a limit column, but currently that is `queryLimit,`
which is the number in query dropdown.
So what I was trying to do here was to make sure that if there is a limit in
the sql itself, that it also gets represented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
