AAfghahi commented on code in PR #20283:
URL: https://github.com/apache/superset/pull/20283#discussion_r890548794
##########
tests/integration_tests/sqllab_tests.py:
##########
@@ -568,7 +568,9 @@ def test_sql_limit(self):
query_limit=test_limit + 1,
)
self.assertEqual(len(data["data"]), test_limit)
- self.assertEqual(data["query"]["limitingFactor"], LimitingFactor.QUERY)
+ self.assertEqual(
+ data["query"]["limitingFactor"], LimitingFactor.QUERY_AND_DROPDOWN
Review Comment:
Yeah I wanted to talk to you about this. Should I transfer the limiting
factor logic into `SqlJsonExecutionContext`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
