eschutho commented on code in PR #20149:
URL: https://github.com/apache/superset/pull/20149#discussion_r890648006


##########
superset/views/core.py:
##########
@@ -282,7 +286,7 @@ def request_access(self) -> FlaskResponse:
         datasource_id = request.args.get("datasource_id")
         datasource_type = request.args.get("datasource_type")
         if datasource_id and datasource_type:
-            ds_class = ConnectorRegistry.sources.get(datasource_type)
+            ds_class = DatasourceDAO.sources.get(datasource_type)

Review Comment:
   DatasourceDAO.sources should be able to take either a string or the 
DatasourceType instance, so I think either works here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to