eschutho commented on code in PR #20299:
URL: https://github.com/apache/superset/pull/20299#discussion_r891773799
##########
superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx:
##########
@@ -232,6 +262,20 @@ class DatasourceControl extends React.PureComponent {
</Menu>
);
+ const queryDatasourceMenu = (
+ <Menu onClick={this.handleMenuItemClick}>
+ <Menu.Item key={QUERY_PREVIEW}>{t('Query preview')}</Menu.Item>
+ <Menu.Item key={VIEW_IN_SQL_LAB}>{t('View in SQL Lab')}</Menu.Item>
+ <Menu.Item key={SAVE_AS_DATASET}>{t('Save as dataset')}</Menu.Item>
+ </Menu>
+ );
+
+ const datasourceTypeCheck =
Review Comment:
do we have this somewhere else? Also the current dataset is SlTable.. but I
think I remember seeing us using Dataset?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
