lyndsiWilliams commented on code in PR #20299:
URL: https://github.com/apache/superset/pull/20299#discussion_r892879234
##########
superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx:
##########
@@ -264,7 +302,11 @@ class DatasourceControl extends React.PureComponent {
<WarningIconWithTooltip warningMarkdown={extra.warning_markdown} />
)}
<AntdDropdown
- overlay={datasourceMenu}
+ overlay={
+ isValidDatasourceType(datasource.type)
+ ? queryDatasourceMenu
Review Comment:
This only shows the query dropdown if the datasource is a query, it should
not be showing at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
