AAfghahi commented on code in PR #20338:
URL: https://github.com/apache/superset/pull/20338#discussion_r893976258
##########
superset/charts/schemas.py:
##########
@@ -854,6 +854,7 @@ class ChartDataExtrasSchema(Schema):
having_druid = fields.List(
fields.Nested(ChartDataFilterSchema),
description="HAVING filters to be added to legacy Druid datasource
queries.",
+ deprecated= True,
Review Comment:
I think so, I thought originally that this was an actual column on the
model. Question though, if we remove this what do we write here:
https://github.com/apache/superset/blob/master/superset/common/query_object.py#L74
do we need to redirect people at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
