betodealmeida commented on code in PR #20338:
URL: https://github.com/apache/superset/pull/20338#discussion_r893996477
##########
superset/utils/core.py:
##########
@@ -1746,18 +1748,6 @@ def get_time_filter_status(
"column": ExtraFiltersTimeColumnType.TIME_ORIGIN,
}
)
-
- if ExtraFiltersTimeColumnType.GRANULARITY in applied_time_extras:
- if datasource.type == "druid":
- applied.append({"column": ExtraFiltersTimeColumnType.GRANULARITY})
- else:
- rejected.append(
- {
- "reason": ExtraFiltersReasonType.NOT_DRUID_DATASOURCE,
- "column": ExtraFiltersTimeColumnType.GRANULARITY,
- }
- )
Review Comment:
Or maybe not, `ExtraFiltersReasonType.NOT_DRUID_DATASOURCE` suggests that
this whole part of the code is Druid only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
