stevetracvc opened a new pull request, #20353:
URL: https://github.com/apache/superset/pull/20353

   ### SUMMARY
   Currently, for the conditional color scaling, alpha is directly proportional 
to the value. This PR adds a checkbox to the Conditional Formatting modal that 
allows the designer to invert this scale, ie, as the value increases, the alpha 
_decreases_
   
   Additionally, this fixes an issue I noticed with #20016 that broke the 
conditional formatting feature (need to convert hex string to 'rgb(R,G,B)' 
string).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Regular conditional formatting:
   
![regular](https://user-images.githubusercontent.com/70416691/173202684-276f4ca1-eb7d-46cd-adf8-60d21eeb5dc7.png)
   
   Inverted for Rank
   
![inverted](https://user-images.githubusercontent.com/70416691/173202690-4b23768a-df06-4edb-b8e5-7a6995d8658a.png)
   
   
   ### TESTING INSTRUCTIONS
   - Create a table with numeric values
   - Add a conditional formatting under the Customize tab
   - Toggle the checkbox to see the effect
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [X] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to