stevetracvc commented on code in PR #20353:
URL: https://github.com/apache/superset/pull/20353#discussion_r895621944
##########
superset-frontend/packages/superset-ui-chart-controls/test/utils/getColorFormatters.test.ts:
##########
@@ -133,6 +195,21 @@ describe('getColorFunction()', () => {
expect(colorFunction(100)).toEqual('rgba(255,0,0,1)');
});
+ // it('getColorFunction EQUAL inverse', () => {
Review Comment:
I left it in so I'd remember to ask...Is there any reason to try to make
this work with the equals operator? I haven't really used the conditional
formatting feature much, but it looks like equals will only color cells that
are exactly equal, and at 100% opacity, so there's no need to be able to
inverse it. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
