diegomedina248 opened a new pull request, #20402:
URL: https://github.com/apache/superset/pull/20402

   ### SUMMARY
   
   For the alert and reports, the active toggle could lag and give the user the 
impression nothing is happening.
   This PR just uses an optimistic update instead, and revert the change if the 
API fails.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   
https://user-images.githubusercontent.com/17252075/173914874-b585db66-5975-4039-817e-fb92eeb16cb6.mov
   
   After:
   
   
https://user-images.githubusercontent.com/17252075/173914186-9e65add3-2193-4809-93b3-adf65eea86f6.mov
   
   ### TESTING INSTRUCTIONS
   
   1. go to the alerts page
   2. toggle the alert on and off
   
   The expected result is that the user sees the toggle pretty quickly.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to