michael-s-molina commented on code in PR #20402:
URL: https://github.com/apache/superset/pull/20402#discussion_r902580795
##########
superset-frontend/src/views/CRUD/alert/AlertList.tsx:
##########
@@ -188,14 +189,32 @@ function AlertList({
const initialSort = [{ id: 'name', desc: true }];
- const toggleActive = (data: AlertObject, checked: boolean) => {
- if (data && data.id) {
- const update_id = data.id;
- updateResource(update_id, { active: checked }).then(() => {
- refreshData();
- });
- }
- };
+ const toggleActive = useCallback(
+ (data: AlertObject, checked: boolean) => {
+ if (data && data.id) {
+ const update_id = data.id;
+ const original = [...alerts];
+
+ setResourceCollection(
+ original.map(alert => {
+ if (alert?.id === data.id) {
+ return {
+ ...alert,
+ active: checked,
+ };
+ }
+
+ return alert;
+ }),
+ );
+
+ updateResource(update_id, { active: checked }, false, false)
+ .then()
+ .catch(() => setResourceCollection(original));
Review Comment:
Shouldn't we display a toast for the user like "An error occurred while
changing the active state"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
