diegomedina248 commented on code in PR #20442:
URL: https://github.com/apache/superset/pull/20442#discussion_r903036487
##########
superset-frontend/src/components/ImportModal/ErrorAlert.tsx:
##########
@@ -31,31 +31,36 @@ export const DOCUMENTATION_LINK = supersetTextDocs
export interface IProps {
errorMessage: string;
+ dbInstall: boolean;
}
-const ErrorAlert: FunctionComponent<IProps> = ({ errorMessage }) => (
+const ErrorAlert: FunctionComponent<IProps> = ({ errorMessage, dbInstall }) =>
(
<Alert
closable={false}
css={(theme: SupersetTheme) => antdWarningAlertStyles(theme)}
type="error"
showIcon
message={errorMessage}
description={
- <>
- <br />
- {t(
- 'Database driver for importing maybe not installed. Visit the
Superset documentation page for installation instructions:',
- )}
- <a
- href={DOCUMENTATION_LINK}
- target="_blank"
- rel="noopener noreferrer"
- className="additional-fields-alert-description"
- >
- {t('here')}
- </a>
- .
- </>
+ dbInstall ? (
Review Comment:
`showDbInstallInstructions` or something similar? The name seems a bit
cryptic to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
