cccs-RyanK opened a new pull request, #20466: URL: https://github.com/apache/superset/pull/20466
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Splits the Synchronous and Asynchronous behaviour of the Select component into two separate components. It's very clear that the behaviors are different and we can significantly reduce code complexity if we treat them as different components. This task was outlined as a part of this PR by @michael-s-molina : https://github.com/apache/superset/pull/20143 Most of the use cases for the select component are synchronous at the moment, so the default "Select" component will remain the synchronous Select. "AsyncSelect" is the new component for asynchronous use cases. For this PR, the files remain identical to ensure nothing will be broken, but references to the Select Component that have asynchronous options have been changed to reference AsyncSelect. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
