michael-s-molina commented on PR #20466:
URL: https://github.com/apache/superset/pull/20466#issuecomment-1163429864
Thanks for the PR @cccs-RyanK!
Some suggestions to complete this PR and the first phase:
1 - You can include this line in `src/components/index.ts` to be able to
import the `AsyncSelect` directly from `src/components`:
`export { default as AsyncSelect } from './Select/AsyncSelect';`
And then import the component with:
`import { AsyncSelect } from 'src/components';`
2 - Don't forget to remove the imports of the sync Select when changing to
AsyncSelect.
3 - Remove the `async -` prefix of the tests in `AsyncSelect.test.tsx`
4 - Remove the `static - ` prefix of the tests in `Select.test.tsx`
5 - Remove the tests in `Select.test.tsx` that contain the `async -` prefix
6 - Split the Select Storybook (`Select.stories.tsx` and
`AsyncSelect.stories.tsx`)
Thanks again! This will really reduce code complexity!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
