yousoph commented on issue #20232:
URL: https://github.com/apache/superset/issues/20232#issuecomment-1170346261

   > Thank you for the SIP! @yousoph. Do you have any concerns with having the 
copy dataset only for virtual datasets? I wonder how this will look after SIP68 
work is complete where there will no longer be a column for virtual or physical?
   
   I think it's okay to have the copy only for virtual datasets (especially 
since there's a limitation on the physical dataset not being able to point to 
the same db table) but agreed that it might be more confusing later on if 
virtual/physical aren't displayed as a column in the list view. 
   
   @jess-dillard do you think physical datasets that can't be copied need some 
explanation, like a disabled duplicate icon with some tooltip text?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to