zuzana-vej commented on issue #20232: URL: https://github.com/apache/superset/issues/20232#issuecomment-1170364681
Definitely +1 for NOT enabling this for physical datasets, only virtual. In terms of virtual datasets, one small concern I have is with the recent changes on ownership of datasets, we would love to prevent cases where users copy dataset, just because they can no longer edit it. Example: Jane D. build dataset and left the company. John Doe wants to edit the dataset, but because he doesn't have access he just goes and copies it, and perhaps changes the chart to use the new dataset. Same scenario can happen in a simpler case when John just doesn't know he needs to ask Jane to be co-onwer to have edit access. As a result, the old dataset is no longer used, although it's not deleted, and it can just cause clutter and confusion. What I am proposing is to make he UX clear in a way that users can decide whether they should edit or copy, and if only thing preventing them from editing it is the fact they are not co-owners, it should be clear to them how to get themselves on the co-owner list (e.g. ask current owner or admins) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
