ktmud opened a new pull request, #20552: URL: https://github.com/apache/superset/pull/20552
### SUMMARY We want to allow users to specify which tabs are selected (and potentially which filters to apply) when generating dashboard reports (see #19354 ). This PR is API changes requires for this to be possible. The following attempt to implement this API (#17749) is generating multiple screenshots with only 1 tab be selectable (and highlighted). This isn't ideal---as there would be no way to compose a view where a combination of certain secondary nested tabs are selected. We want to generate screenshots where the whole dashboard state is preserved, hence this newer approach here. #17749 isn't used by the frontend in any way, so it should be safe to just change it. This PR allows the reports to remember both selected tabs (made possible by #19983) and filter states. We will have separate PRs to enable each in the frontend. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TESTING INSTRUCTIONS We rely on unit tests. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
