ktmud commented on code in PR #20552:
URL: https://github.com/apache/superset/pull/20552#discussion_r928025338
##########
superset/reports/commands/execute.py:
##########
@@ -640,11 +633,13 @@ class AsyncExecuteReportScheduleCommand(BaseCommand):
- On Alerts uses related Command AlertCommand and sends configured
notifications
"""
- def __init__(self, task_id: str, model_id: int, scheduled_dttm: datetime):
+ def __init__(
+ self, task_id: Union[UUID, str], model_id: int, scheduled_dttm:
datetime
Review Comment:
Because the unittest generates a UUID directly and I didn't want to convert
it to string then to uuid again... but you are right, I shouldn't make the app
code more complex just to accommodate testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
