rusackas opened a new pull request, #20571: URL: https://github.com/apache/superset/pull/20571
…itive values (#20408)" This reverts commit c959d92dd17499e3fb7a0f4f02f3781516f3d3e6. The PR being reverted bumped echarts and changes the stacking method to allow proper stacking of negative values (cool!). However, if a dataset happens to display `null` values as bar segments, clicking on the legend causes the chart display to become VERY erratic in terms of what's displayed/hidden in the stacked bars - things disappear completely! <!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://user-images.githubusercontent.com/812905/176741409-6d0aaffe-4af4-4e10-802e-2f1ae591d1f0.mp4 After: coming soon... but it works, trust me ;) <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Create a dataset with this query ```sql SELECT TO_DATE('2011-01-01', 'yyyy-MM-dd') as d, 1 as city, 1 as count union all SELECt TO_DATE('2011-01-01', 'yyyy-MM-dd'), 1, 1 union all SELECt TO_DATE('2011-01-01', 'yyyy-MM-dd'), 1, null union all SELECt TO_DATE('2011-01-01', 'yyyy-MM-dd'), 2, 1 union all SELECt TO_DATE('2011-01-01', 'yyyy-MM-dd'), 2, null union all SELECt TO_DATE('2012-01-01', 'yyyy-MM-dd'), 2, null union all SELECt TO_DATE('2013-01-01', 'yyyy-MM-dd'), 2, null union all SELECt TO_DATE('2013-01-01', 'yyyy-MM-dd'), 2, 1 ``` ...then make Timeseries Bar Chart V2 as shown in the GIF. Click around on the labels and see if you see all the right bars at all times. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [x] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
