codyml commented on PR #20612:
URL: https://github.com/apache/superset/pull/20612#issuecomment-1176274955

   > Hi @codyml.
   > IMHO blue color uses in info icons but a required field alway uses red 
color to better notice it
   
   The motivation for this was to not show red right away on new charts because 
it can make the user think they've done something wrong right from the 
beginning, which isn't great for user experience.  But, I'm going to darken the 
blue color, which hopefully will make it a little more visible, and I'm also 
going to try to change it so it's only blue if they've never added an item to a 
required field on a new chart, and after that if they clear a required field on 
a new or existing chart it'll show the error in red.  Does that sound like a 
good improvement?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to