codyml commented on code in PR #20612:
URL: https://github.com/apache/superset/pull/20612#discussion_r930442234
##########
superset-frontend/src/explore/components/ControlPanelsContainer.tsx:
##########
@@ -58,6 +58,11 @@ import { ChartState, ExplorePageState } from
'src/explore/types';
import { Tooltip } from 'src/components/Tooltip';
import { rgba } from 'emotion-rgba';
+import { kebabCase } from 'lodash';
+import {
+ ExclamationCircleOutlined,
+ InfoCircleOutlined,
+} from '@ant-design/icons';
Review Comment:
Actually, it turns out the directly-imported AntD icons render different
HTML/styles from the `Icons`-rendered ones: there's an extra wrapper element
and it resets the font size. I found 10 or so instances of directly importing
AntD icons and swapping them out caused a bunch of layout bugs. I need to look
into this further to try to fix the layout bug you found above, because I think
that may be caused by my inconsistently switching to direct AntD import in some
places in this PR, but I think switching them out across the codebase will be a
more involved process that might be better done in a different PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
