john-bodley commented on code in PR #20499:
URL: https://github.com/apache/superset/pull/20499#discussion_r906619409
##########
superset/security/manager.py:
##########
@@ -1469,3 +1464,63 @@ def has_guest_access(self, dashboard: "Dashboard") ->
bool:
if str(resource["id"]) == str(dashboard.embedded[0].uuid):
return True
return False
+
+ def raise_for_ownership(self, resource: Model) -> None:
+ """
+ Raise an exception if the user does not own the resource.
+
+ Note admins are deemed owners of all resources.
+
+ :param resource: The dashboard, dataste, chart, etc. resource
+ :raises SupersetSecurityException: If the current user is not an owner
+ """
+
+ if self.is_admin():
+ return
+
+ # Set of owners that works across ORM models.
+ owners: Set[User] = set()
Review Comment:
The `check_ownership` method would refetch the resource from the database
but I'm not sure as to why. Is the concern that the ownership information may
have change from the time of the request? If so I'm not sure we deal with these
types of race conditions elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
