john-bodley commented on PR #20499: URL: https://github.com/apache/superset/pull/20499#issuecomment-1177911179
@dpgaspar > On the other hand we will loose some future flexibility if we would ever wanted to use DAO or commands with different users, celery context for example? I don't disagree in terms of lose of flexibility, however the `g.user` is so engrained in the entire application workflow that we would need a very major refactor in order to support this. Per the PR description the actor is somewhat misleading given that some checks are in relation to the specified actor whereas others (like `is_user_admin` et al.) are based on `g.user`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
