eschutho commented on code in PR #20629:
URL: https://github.com/apache/superset/pull/20629#discussion_r915274329
##########
superset/charts/post_processing.py:
##########
@@ -325,9 +325,16 @@ def apply_post_process(
for query in result["queries"]:
if query["result_format"] == ChartDataResultFormat.JSON:
- df = pd.DataFrame.from_dict(query["data"])
+ try:
+ df = pd.DataFrame.from_dict(query["data"])
+ except ValueError: # no data error
+ return result
Review Comment:
@betodealmeida if the data is None or '', is there any value in continuing
this process rather than returning early? AFAICT we'll continue to get more
errors down below as well. Per @john-bodley's point, I can do a nullish check
instead of the try/except if we want to be more specific to these errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
