eschutho commented on code in PR #20629:
URL: https://github.com/apache/superset/pull/20629#discussion_r916347837
##########
superset/charts/post_processing.py:
##########
@@ -325,9 +325,16 @@ def apply_post_process(
for query in result["queries"]:
if query["result_format"] == ChartDataResultFormat.JSON:
- df = pd.DataFrame.from_dict(query["data"])
+ try:
+ df = pd.DataFrame.from_dict(query["data"])
+ except ValueError: # no data error
+ return result
Review Comment:
@john-bodley I tested out None and empty string with both the CSV and JSON
formats, and JSON will error for both, and CSV only on `''` as you noted. I'm
concerned that that logic of checking for validity could get even more
complicated if the code changes in any way. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
