hughhhh commented on code in PR #20281:
URL: https://github.com/apache/superset/pull/20281#discussion_r917795493
##########
superset-frontend/packages/superset-ui-core/src/query/types/Column.ts:
##########
@@ -38,7 +38,7 @@ export type PhysicalColumn = string;
* Column information defined in datasource.
*/
export interface Column {
- id: number;
+ id?: number;
Review Comment:
When it's of type datasource is `Query` we don't have an id for this object,
since we are just saving it has a JSON blob inside `extra_json`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
