ktmud commented on code in PR #20799:
URL: https://github.com/apache/superset/pull/20799#discussion_r929093918
##########
superset/db_engine_specs/hive.py:
##########
@@ -366,21 +366,14 @@ def handle_cursor( # pylint: disable=too-many-locals
query.progress = progress
needs_commit = True
if not tracking_url:
- tracking_url = cls.get_tracking_url(log_lines)
+ tracking_url = cls.get_tracking_url_from_logs(log_lines)
if tracking_url:
job_id = tracking_url.split("/")[-2]
logger.info(
"Query %s: Found the tracking url: %s",
str(query_id),
tracking_url,
)
- transformer =
current_app.config["TRACKING_URL_TRANSFORMER"]
Review Comment:
Yes, there is a test case for it:
https://github.com/apache/superset/pull/20799/files#diff-bbedc6245e80199586380e684695b5a8e275fd95c46f6770b91eb0bb918e2bf5R52-R53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
