ktmud commented on code in PR #20799:
URL: https://github.com/apache/superset/pull/20799#discussion_r929094751
##########
superset/db_engine_specs/presto.py:
##########
@@ -957,8 +963,23 @@ def get_create_view(
return rows[0][0]
@classmethod
- def handle_cursor(cls, cursor: Any, query: Query, session: Session) ->
None:
+ def get_tracking_url(cls, cursor: "Cursor") -> Optional[str]:
+ try:
+ if cursor.last_query_id:
+ # pylint: disable=protected-access, line-too-long
+ return
f"{cursor._protocol}://{cursor._host}:{cursor._port}/ui/query.html?{cursor.last_query_id}"
+ except AttributeError:
+ pass
Review Comment:
Final return is expected to be explicit if you have a return statement
earlier. I think there is a pylint or mypy warning for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
