zhaoyongjie commented on PR #20728: URL: https://github.com/apache/superset/pull/20728#issuecomment-1194867520
> I believe the samples pane in Explore should also account for these filters. If I set is_software_dev = 1 I don't expect to see samples where this condition is not true. It's not true. The `SamplesPane` implies **sampling the data source** and has no relation to the chart. V1 API is at [here](https://github.com/apache/superset/blob/6b0c3032b28a606fedefa7552823c6e18a95a563/superset/common/query_actions.py#L144), legacy API is at [here](https://github.com/apache/superset/blob/6b0c3032b28a606fedefa7552823c6e18a95a563/superset/viz.py#L252). ----------- It is a point worth discussing why the original implementation did not reset the `filter` fields in the `QueryObject`? IMO, It's a bug. The filters should be applied `where clause` or `having clause` in the query. The `metrics` has been reset on the `QueryObject`, so we did not have a chance to send a query with `having clause`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
