codyml commented on code in PR #20728:
URL: https://github.com/apache/superset/pull/20728#discussion_r929930818
##########
superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx:
##########
@@ -39,6 +45,8 @@ import ModalTrigger from 'src/components/ModalTrigger';
import Button from 'src/components/Button';
import ViewQueryModal from 'src/explore/components/controls/ViewQueryModal';
import { ResultsPaneOnDashboard } from 'src/explore/components/DataTablesPane';
+import Modal from 'src/components/Modal';
+import DrillDetailPane from 'src/dashboard/components/DrillDetailPane';
Review Comment:
I had it as the default export because it's the only export of the directory
as the wiki suggests:
> Default VS named exports: As recommended by
[Typescript](https://www.typescriptlang.org/docs/handbook/modules.html), “If a
module’s primary purpose is to house one specific export, then you should
consider exporting it as a default export. This makes both importing and
actually using the import a little easier”. If you’re exporting multiple
objects, use named exports instead.
That ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
