AAfghahi commented on code in PR #20869:
URL: https://github.com/apache/superset/pull/20869#discussion_r932367749
##########
superset-frontend/src/views/routes.tsx:
##########
@@ -189,6 +197,14 @@ export const routes: Routes = [
path: '/superset/explore/p',
Component: ExplorePage,
},
+ {
+ path: '/dataset/add/',
+ Component: DatasetEditor,
+ },
+ {
+ path: '/dataset/:datasetId',
+ Component: DatasetEditor,
Review Comment:
No this was based on a previous understanding of the code, I changed it to
reflect the components more accurately.
I did reuse the header component, so I moved it one level higher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
