eschutho commented on code in PR #20869:
URL: https://github.com/apache/superset/pull/20869#discussion_r932611384
##########
superset/views/datasource/views.py:
##########
@@ -203,3 +203,27 @@ def samples(self) -> FlaskResponse:
payload=payload,
)
return self.json_response({"result": rv})
+
+
+class DatasetEditor(BaseSupersetView):
+ route_base = "/dataset"
+ class_permission_name = "Dataset"
+
+ @expose("/add/")
+ @has_access
+ @permission_name("read")
Review Comment:
what sort of permissions does this map to? Who has permission to read this
page? Wouldn't this be edit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
