[GitHub] [superset] kasiazjc commented on pull request #21040: feat: Add label and tooltip for the color schemes control

[GitBox]

kasiazjc commented on PR #21040:
URL: https://github.com/apache/superset/pull/21040#issuecomment-1216520438

   > Code looks good and it works! Left two comments that are not blocking. The 
double truncation does strike me as kind of strange: the row of swatches starts 
at a different place for each item so the menu looks a little chaotic, and as a 
user I think my first impression of seeing two ellipses in one menu item would 
be that there's a layout bug. I can't think of a perfect alternative, but what 
about if we made it so we had a max of like 10 swatches and they were 
right-justified without an ellipsis, and then the title is left-justified, 
truncated with an ellipsis always at the same point? We wouldn't see the max 
amount of information possible but it would look a lot cleaner and the tooltips 
would show the full content.
   > 
   > <img alt="Screen Shot 2022-08-12 at 5 43 57 PM" width="667" 
src="https://user-images.githubusercontent.com/13007381/184457442-67066c0e-e62f-4af1-bf94-902136b75c8f.png";>
   > 
   > But, also non-blocking if we want to stick with this design.
   
   Thanks for the feedback Cody! I think actually that is a good idea. We still 
need an indicator that not all of the colors are shown and I'm thinking - maybe 
let's add a counter? So, as in the categorical color palette, max number of 
colors is 12, let's use it's a max shown. It will be the fixed with for the 
color swatches section. Then between text and colors there is 8px fixed spacing 
and the rest is title. Does it make sense? All of the things would cut off in 
the same space and it would declutter the whole thing a little bit. What do you 
think @geido 
   
   <img width="879" alt="image" 
src="https://user-images.githubusercontent.com/36897697/184870687-a675e98b-2071-408a-bea4-0f6267502f1a.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org