kasiazjc commented on PR #21040: URL: https://github.com/apache/superset/pull/21040#issuecomment-1218216263
> > Thanks for the feedback Cody! I think actually that is a good idea. We still need an indicator that not all of the colors are shown and I'm thinking - maybe let's add a counter? So, as in the categorical color palette, max number of colors is 12, let's use it's a max shown. It will be the fixed with for the color swatches section. Then between text and colors there is 8px fixed spacing and the rest is title. Does it make sense? All of the things would cut off in the same space and it would declutter the whole thing a little bit. What do you think @geido > > <img alt="image" width="879" src="https://user-images.githubusercontent.com/36897697/184870687-a675e98b-2071-408a-bea4-0f6267502f1a.png";> > > @kasiazjc the two elements cannot be located at the opposite ends as the container can be dragged and expanded. This would create a potential huge space between the label and the colors. > > In order to keep this flexible we also should not set a maximum number of 12 colors as the dropdown should behave based on the available horizontal space. > > As for changing from ellipsis to a number of hidden colors, that would require a bigger refactor and if we think it is critical we should discuss that option and I can open another PR. > > In the meantime, I made some enhancements so that the options do not look disordered and all consume the same space now, which should satisfy what @codyml was asking above. Also, These latest changes truncates both the labels and colors less often, which should improve the feelings about double truncation. > >  Oh, I understand. I actually think it looks good! I am totally fine with merging this version. Thank you Diego for working on it 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/36897697/184870687-a675e98b-2071-408a-bea4-0f6267502f1a.png"](https://user-images.githubusercontent.com/36897697/184870687-a675e98b-2071-408a-bea4-0f6267502f1a.png"){kind=link}
