villebro commented on PR #21154:
URL: https://github.com/apache/superset/pull/21154#issuecomment-1225223344
> Thanks for the info, that's the kind of thing I was worried about. One
idea I had was to extend the query object to include the `x_axis` field that
the frontend sends in `form_data`, and use that to conditionally exclude the
`x_axis` column in that part of the code, which hopefully would leave legacy
charts that don't support generic x-axis unaffected. Do you think that would
work?
IMO including `x_axis` in the query object would be what we in Swedish call
"tårta på tårta" ("cake on cake" in English referring to unnecessary
redundancy), as `x_axis` should always be the complement of `columns` (`x_axis
+ series_columns = columns`). Incidentally, if we do want to reference `x_axis`
in that part of the codebase, I would recommend calling it `base_axes` and
making it a list/tuple of columns, as we may want to start introducing 3D
charts or similar at some point, in which case there would be two base axes.
But back to the problem at hand - I have a hypothesis that I will validate
now that should be uninvasive. Let me try it out and post my findings so we can
get this fix merged asap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
