villebro commented on code in PR #21154:
URL: https://github.com/apache/superset/pull/21154#discussion_r954038488
##########
superset/connectors/sqla/models.py:
##########
@@ -1410,7 +1410,7 @@ def get_sqla_query( # pylint:
disable=too-many-arguments,too-many-locals,too-ma
col=selected, template_processor=template_processor
)
groupby_all_columns[outer.name] = outer
- if not series_column_names or outer.name in
series_column_names:
+ if outer.name in series_column_names:
Review Comment:
The legacy time series line, bar etc charts. Essentially the ones with
`is_timeseries` set to `True` and that are served by `viz.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
